🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 6961b8c)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 6961b8c)

PyQgsLayerTreeView crashes on QT6 https://github.com/qgis/QGIS/actions/runs/11690407551/job/32556700307?pr=59337

@nyalldawson @rouault do you have an idea why the Qt6 test has a segfault? I can run the test in both Qt5 and Qt6 on my machine and it is fine...

Is seems as if the Qt6 test uses the code without my modifications...

I can run the test in both Qt5 and Qt6 on my machine and it is fine...

did you try running under Valgrind, just in case this might be something subtle... Or maybe it is due to a difference of Qt6 versions between your machine and the CI one ?

@Djedouas looks like the test is actually hanging and timing out and being forcefully closed. But I can't see anything here that would lead to a hang... 🤔

I'd check if it's the new test causing this (as opposed to an existing test impacted by these changes) by temporarily removing it...

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

• that all unit tests are passing

• that all comments by reviewers have been addressed

• that there is enough information for reviewers, in particular

  • link to any issues which this pull request fixes

  • add a description of workflows which this pull request fixes

  • add screenshots if applicable

• that you have written unit tests where possible
  In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
  If there is no further activity on this pull request, it will be closed in a week.

@nyalldawson @rouault Fixed the test by adding more checks on potentially nullptr:

• layerTreeModel()
• selectedModel()
• mProxyModel

The backport to queued_ltr_backports failed:

The process '/usr/bin/git' failed with exit code 1

error: could not apply 6961b8cbc61... fix(layertreeview): add checks on nullptr to avoid segfaults
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Auto-merging src/gui/layertree/qgslayertreeview.cpp
CONFLICT (content): Merge conflict in src/gui/layertree/qgslayertreeview.cpp
Auto-merging tests/src/python/test_qgslayertreeview.py

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-queued_ltr_backports queued_ltr_backports
# Navigate to the new working tree
cd .worktrees/backport-queued_ltr_backports
# Create a new branch
git switch --create backport-59337-to-queued_ltr_backports
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 6961b8cbc61bd59e27f09bd8c8fb57eefb9cad9d
# Push it to GitHub
git push --set-upstream origin backport-59337-to-queued_ltr_backports
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-queued_ltr_backports

Then, create a pull request where the base branch is queued_ltr_backports and the compare/head branch is backport-59337-to-queued_ltr_backports.

The backport to release-3_34 failed:

The process '/usr/bin/git' failed with exit code 1

error: could not apply 6961b8cbc61... fix(layertreeview): add checks on nullptr to avoid segfaults
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Auto-merging src/gui/layertree/qgslayertreeview.cpp
CONFLICT (content): Merge conflict in src/gui/layertree/qgslayertreeview.cpp
Auto-merging tests/src/python/test_qgslayertreeview.py

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3_34 release-3_34
# Navigate to the new working tree
cd .worktrees/backport-release-3_34
# Create a new branch
git switch --create backport-59337-to-release-3_34
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 6961b8cbc61bd59e27f09bd8c8fb57eefb9cad9d
# Push it to GitHub
git push --set-upstream origin backport-59337-to-release-3_34
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3_34

Then, create a pull request where the base branch is release-3_34 and the compare/head branch is backport-59337-to-release-3_34.